Ticket #79 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

argument verb has bad test for valid parent

Reported by: scorfield Owned by: scorfield
Type: defect Priority: high
Milestone: Release Candidate 1 Component: Miscellaneous
Version: 5.0 Severity: normal
Keywords: Cc:

Description

Tim Mixell spotted that the test for valid parent is reversed in the argument verb.

Attachments

Change History

Changed 2 years ago by scorfield

  • owner changed from sean@corfield.org to scorfield
  • status changed from new to assigned

You'll also need to make two changes in instantiate.cfm to fix this properly:

Line 57 - the assignment of "" to fb_.verbInfo.attributes.arguments should be removed.

Line 121 (formerly line 122) - the condition for assigning the new value of fb.verbInfo.arguments should be changed to this:

if (not structKeyExists(fb_.verbInfo.attributes,"arguments")) {

Changed 2 years ago by scorfield

  • status changed from assigned to closed
  • resolution set to fixed

(In [193]) Fixes #79 by correcting the test for parent verbs and fixing how instantiate handles the arguments attribute.

Changed 2 years ago by scorfield

  • status changed from closed to reopened
  • resolution deleted

There are still some edge cases with this that cause problems.

Changed 2 years ago by scorfield

  • status changed from reopened to closed
  • resolution set to fixed

(In [198]) Fixes #79 by using a local variable for the modified arguments list.

Note: See TracTickets for help on using tickets.