Ticket #158 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Better error when phase contains non-plugin declarations

Reported by: scorfield Owned by: scorfield
Type: enhancement Priority: normal
Milestone: Fusebox 5.1 Component: Miscellaneous
Version: 5.0 Severity: normal
Keywords: Cc:

Description

A user did this by accident:

<phase name="postProcess">
<do action="layouts.buildPage"/>
</phase>

The error was:

Required attribute is missing
The attribute 'name' is required, for a 'postProcess' plugin declaration in fusebox.xml.

It would be more helpful to complain that 'do' is not valid inside a 'phase' declaration.

Attachments

Change History

Changed 2 years ago by scorfield

  • owner changed from sean@corfield.org to scorfield
  • status changed from new to assigned
  • version changed from 5.0 to 5.1

This is a no brainer. 5.1 should absolutely do this.

Changed 2 years ago by scorfield

  • version changed from 5.1 to 5.0
  • milestone set to Fusebox 5.1

Changed 2 years ago by scorfield

  • status changed from assigned to closed
  • resolution set to fixed

(In [262]) Fixes #158 by moving the attribute check for plugins inside the (existing) conditional that checked the declaration's xmlName.

Note: See TracTickets for help on using tickets.